overlay/20live: persist osmet files#322
Conversation
|
Requires: coreos/coreos-assembler#1244 |
|
This will persistently take up RAM even if the user isn't going to do an install, right? We could fix that by doing e.g. |
|
We don't have access to the initrd in a live scenario though, right? (I mean, other than it already being loaded in RAM in the first place). I guess in the live ISO case where the media isn't removed yet, you could use that, though for 5M seems cleaner to just have it work the same across all live scenarios. |
|
One related thing is |
cgwalters
left a comment
There was a problem hiding this comment.
OK yeah, not worth worrying about a few MB right now.
We need to make sure that the osmet files in the initrd are kept somewhere accessible in the real root where coreos-installer will find them. Have a simple unit which copies them over to the right spot.
|
I just tweaked this slightly so that it doesn't error out if no osmet files are present. That way it's safe to merge this right now so that we can use it in the CI for coreos/coreos-installer#187. Feel free to do another review. Otherwise will merge on green! |
We need to make sure that the osmet files in the initrd are kept
somewhere accessible in the real root where coreos-installer will find
them. Have a simple unit which copies them over to the right spot.